| davidedmundson |
| Plasma |
Just because the item is visible doesn't mean the window itself is. Keep track of the window it's in.
Use itemChange instead of connects and move the check for starting to startRedirect so we don't have to check the conditions for that in every change handler (visible && enabled && window->visible). It also saves three connects in the constructor.
Also, don't unredirect if we didn't redirect in the first place to avoid warnings printed on console.
BUG: 406303
Window thumbnails still work
Don't have fds pile up anymore
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I recall there was also a bug about "games becoming slow when hovering them in task bar" which might be the same bug: us not unredirecting it again
| src/declarativeimports/core/windowthumbnail.cpp | ||
|---|---|---|
| 213 | Do you actually need Q_FALLTHROUGH() here? | |
| src/declarativeimports/core/windowthumbnail.cpp | ||
|---|---|---|
| 213 | I fall through so I wanted to make it explicit. I would have put a // fallthrough comment otherwise | |