[kcmkwin/kwintabbox] Use a more appropriate icon
ClosedPublic
Actions

Authored by ngraham on Apr 25 2019, 2:18 AM.

Details

Reviewers

Group Reviewers

VDG
KWin

Commits

Summary

The current icon (window-duplicate) is semantically incorrect and visually disconnected from what it actually does.

This one is much more appropriate on both counts.

Test Plan

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptApr 25 2019, 2:18 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

ngraham requested review of this revision.Apr 25 2019, 2:18 AM

zzag added inline comments.

kcmkwin/kwintabbox/kwintabbox.desktop
4	Is this icon choice good though? It would be great to have some alias (e.g. preferences-desktop-tabbox -> preferences-system-windows-effect-flipswitch) and use it instead.

Use a more generically appropriate icon name

This revision is now accepted and ready to land.Apr 25 2019, 1:17 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcmkwin/kwintabbox/kwintabbox.desktop (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56940	32863aa		Apr 25 2019, 2:18 AM	★	★
Diff 2	56957	32863aa	Use a more generically appropriate icon name	Apr 25 2019, 1:11 PM	★	★
Diff 3	56967	b37743d	R108:4725ece602902d86a6ff3a51157a21fb3adaa828	Apr 25 2019, 1:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2a59f46ccce5	2ead10a469a8	32863aac9b69	Nate Graham	[kcmkwin/kwintabbox] Use a more appropriate icon (Show More…)	Apr 25 2019, 2:16 AM