[Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI
ClosedPublic

Authored by ngraham on Wed, Apr 24, 9:51 PM.

Details

Summary
  • Port to QQC2+Kirigami FormLayout
  • Adjust some strings to be more natural
  • Fix some incorrect strings when being an Activity pager rather than a Virtual Desktop pager
Test Plan

All features still work.

Virtual Desktops:

Activities:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Wed, Apr 24, 9:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Apr 24, 9:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Wed, Apr 24, 9:51 PM
ngraham updated this revision to Diff 56926.Wed, Apr 24, 9:57 PM

Also correct category icon

GB_2 added a subscriber: GB_2.Wed, Apr 24, 10:24 PM

Looks good UI-wise.

applets/pager/package/contents/ui/configGeneral.qml
136

Default radio buttons should be at the top.

ngraham updated this revision to Diff 56941.Thu, Apr 25, 2:27 AM
ngraham marked an inline comment as done.

Re-arrange radio buttons so the default one is on top

ngraham edited the summary of this revision. (Show Details)Thu, Apr 25, 2:27 AM
ngraham edited the test plan for this revision. (Show Details)
GB_2 accepted this revision as: VDG, GB_2.Thu, Apr 25, 7:05 PM

Perfect.

This revision is now accepted and ready to land.Thu, Apr 25, 7:05 PM
This revision was automatically updated to reflect the committed changes.