Remove warning - modernize: pass an argument by values and use std::move()
Needs ReviewPublic

Authored by andreagenor on Wed, Apr 24, 9:31 PM.

Details

Reviewers
tcanabrava
pino
Summary

Signed-off-by: André Agenor <andreagenor@icloud.com>

Diff Detail

Repository
R374 KolourPaint
Branch
fix/modernize-pass-by-values-and-use-std-move
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11221
Build 11239: arc lint + arc unit
andreagenor requested review of this revision.Wed, Apr 24, 9:31 PM
andreagenor created this revision.
pino requested changes to this revision.Wed, Apr 24, 9:59 PM
pino added a subscriber: pino.

Using std::move for these cases is not needed:

  • QString parameters are better passed as const&, so they are not copied nor moved
  • QColor parameters can be passed by value, as they are trivial to copy
This revision now requires changes to proceed.Wed, Apr 24, 9:59 PM
  • Correct the use of QString removing std::move
  • Remove unnecessary headers
  • Add blank line to come back as original