Differential D20793

Simplify GenericGrantleeFormatter
ClosedPublic
Actions

Authored by vkrause on Apr 24 2019, 6:15 PM.

Details

Reviewers
knauss
mlaurent
Commits
R95:e1fc3bbf66b4: Simplify GenericGrantleeFormatter
Summary

Mainly removing unneeded indirections to make this easier to read. The
next step is then moving this to grantleethemes so we can use the i18n
and icon integration for Grantlee here.

Diff Detail

Repository
R95 PIM: Common Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 24 2019, 6:15 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 24 2019, 6:15 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 24 2019, 6:15 PM
knauss accepted this revision.Apr 24 2019, 8:33 PM
knauss added a subscriber: knauss.

seems good.

This revision is now accepted and ready to land.Apr 24 2019, 8:33 PM
mlaurent accepted this revision.Apr 25 2019, 5:05 AM
Closed by commit R95:e1fc3bbf66b4: Simplify GenericGrantleeFormatter (authored by vkrause). · Explain WhyApr 25 2019, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56980

View Options

src/pimcommon/genericgrantlee/genericgrantleeformatter.h

Loading...
View Options

src/pimcommon/genericgrantlee/genericgrantleeformatter.cpp

Loading...