Differential D20792

Avoid nesting Controls in TextField
ClosedPublic
Actions

Authored by davidedmundson on Apr 24 2019, 5:16 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R858:06ea48cd5d4a: Avoid nesting Controls in TextField
Summary

Label now has an extra mousearea conflicting with TextField's mouse
area.

Given we're in the overriding font and colour anyway, we may as well use
Text directly to resolve the bug.

It also saves creating an unused Accessiblity attached object.

One extra property is copied from our Label control for complete parity.

BUG: 406851

Test Plan

Moved the mouse about in systemsettings

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 24 2019, 5:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2019, 5:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Apr 24 2019, 5:16 PM
ngraham accepted this revision.Apr 24 2019, 6:05 PM
This revision is now accepted and ready to land.Apr 24 2019, 6:05 PM
Closed by commit R858:06ea48cd5d4a: Avoid nesting Controls in TextField (authored by davidedmundson). · Explain WhyApr 24 2019, 8:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/TextField.qml (6 lines)

Diff 56921

View Options

org.kde.desktop/TextField.qml

Loading...