process: add support for cgroups
ClosedPublic

Authored by topimiettinen on Wed, Apr 24, 1:03 PM.

Details

Summary

Signed-off-by: Topi Miettinen <toiwoton@gmail.com>

Diff Detail

Repository
R111 KSysguard Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
topimiettinen created this revision.Wed, Apr 24, 1:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Apr 24, 1:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
topimiettinen requested review of this revision.Wed, Apr 24, 1:03 PM
apol added a subscriber: apol.Wed, Apr 24, 1:53 PM
apol added inline comments.
processcore/process.h
215

Just don't return &? I don't understand the comment.

Thanks

processcore/process.h
215

may as well make it non-ref now.

I assume that ref pattern existed as an old way of sscanf-ing directly into the member variables skipping the setBlah call.

processui/ProcessModel.cpp
1035

The control group (cgroup) where this process was belongs.

That doesn't scan right.

s/was // ?

update per comments from @davidedmundson and @apol

topimiettinen marked 3 inline comments as done.Wed, Apr 24, 4:50 PM
davidedmundson accepted this revision.Wed, Apr 24, 4:50 PM
This revision is now accepted and ready to land.Wed, Apr 24, 4:50 PM

It looks like the CGroup rows are visually not vertically aligned to center like other cells, but instead they are aligned to the top. However, I'd expect that the default item of switch in ProcessModel.cpp:1693 should implement this, like it does for e.g. HeadingName. So I'm a bit puzzled why this happens.

Trim trailing newline for proper vertical alignment

phabricate only one git commit, sorry

Looks much better!

fix copy-pasta

hide cgroup column by default

This revision was automatically updated to reflect the committed changes.