Signed-off-by: Topi Miettinen <toiwoton@gmail.com>
Details
Details
- Reviewers
hein davidedmundson - Group Reviewers
Plasma - Commits
- R111:3eb5e842ae64: process: add support for cgroups
Diff Detail
Diff Detail
- Repository
- R111 KSysguard Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| processcore/process.h | ||
|---|---|---|
| 215 | Just don't return &? I don't understand the comment. | |
Comment Actions
Thanks
| processcore/process.h | ||
|---|---|---|
| 215 | may as well make it non-ref now. I assume that ref pattern existed as an old way of sscanf-ing directly into the member variables skipping the setBlah call. | |
| processui/ProcessModel.cpp | ||
| 1035 |
That doesn't scan right. s/was // ? | |
Comment Actions
It looks like the CGroup rows are visually not vertically aligned to center like other cells, but instead they are aligned to the top. However, I'd expect that the default item of switch in ProcessModel.cpp:1693 should implement this, like it does for e.g. HeadingName. So I'm a bit puzzled why this happens.
