Differential D2078

Handle situation of no XDG_RUNTIME_DIR gracefully
ClosedPublic
Actions

Authored by graesslin on Jul 4 2016, 7:51 AM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:3c04d5295d5b: Handle situation of no XDG_RUNTIME_DIR gracefully

Summary

If KWin fails to start the Wayland server due to XDG_RUNTIME_DIR not
being set, kwin_wayland should terminate with an error condition but
not crash.

This change makes sure that KWin detects that the Wayland server does
not work and terminates the startup early and ensures that it doesn't
crash while going down.

An error message is shown that we could not create the Wayland server.

Test Plan

Test case added which verifies that WaylandServer fails to
init. Manual testing that kwin_wayland exits with error 1.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 4924.Jul 4 2016, 7:51 AM

graesslin retitled this revision from to Handle situation of no XDG_RUNTIME_DIR gracefully.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJul 4 2016, 7:51 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependency: D2077: [server] Handle no XDG_RUNTIME_DIR situation more gracefully.Jul 4 2016, 7:52 AM

sebas accepted this revision.Jul 12 2016, 9:17 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Jul 12 2016, 9:17 PM

Closed by commit R108:3c04d5295d5b: Handle situation of no XDG_RUNTIME_DIR gracefully (authored by graesslin). · Explain WhyJul 13 2016, 8:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/integration/CMakeLists.txt (1 line)
M		autotests/integration/debug_console_test.cpp (2 lines)
M		autotests/integration/decoration_input_test.cpp (2 lines)
M		autotests/integration/dont_crash_aurorae_destroy_deco.cpp (2 lines)
M		autotests/integration/dont_crash_cancel_animation.cpp (2 lines)
M		autotests/integration/dont_crash_empty_deco.cpp (2 lines)
M		autotests/integration/dont_crash_glxgears.cpp (2 lines)
M		autotests/integration/dont_crash_no_border.cpp (2 lines)
M		autotests/integration/input_stacking_order.cpp (2 lines)
M		autotests/integration/internal_window.cpp (2 lines)
M		autotests/integration/lockscreen.cpp (2 lines)
M		autotests/integration/maximize_test.cpp (2 lines)
M		autotests/integration/move_resize_window_test.cpp (2 lines)
A	M	autotests/integration/no_xdg_runtime_dir_test.cpp (47 lines)
M		autotests/integration/plasma_surface_test.cpp (2 lines)
M		autotests/integration/plasmawindow_test.cpp (2 lines)
M		autotests/integration/platformcursor.cpp (2 lines)
M		autotests/integration/pointer_input.cpp (2 lines)
M		autotests/integration/quick_tiling_test.cpp (2 lines)
M		autotests/integration/scene_qpainter_test.cpp (2 lines)
M		autotests/integration/shade_test.cpp (2 lines)
M		autotests/integration/shell_client_test.cpp (2 lines)
M		autotests/integration/start_test.cpp (2 lines)
M		autotests/integration/struts_test.cpp (2 lines)
M		autotests/integration/touch_input_test.cpp (2 lines)
M		autotests/integration/transient_no_input_test.cpp (2 lines)
M		autotests/integration/transient_placement.cpp (2 lines)
M		autotests/integration/xclipboardsync_test.cpp (2 lines)
M		main_wayland.cpp (9 lines)
M		wayland_server.h (2 lines)
M		wayland_server.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4924	da36fd1		Jul 4 2016, 7:51 AM	★	★
Diff 2	5112	76fa302	rKWIN3c04d5295d5b25e88201c21e710348bcd618f574	Jul 13 2016, 8:00 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a05757bad570	d9f60d8564fa	da36fd1c0255	Martin Gräßlin	Handle situation of no XDG_RUNTIME_DIR gracefully (Show More…)	Jul 4 2016, 7:09 AM

	Status	Author	Revision
	Closed	graesslin	D2078 Handle situation of no XDG_RUNTIME_DIR gracefully
	Closed	graesslin	D2077 [server] Handle no XDG_RUNTIME_DIR situation more gracefully