makes KFileMetaData optional again
ClosedPublic

Authored by mgallien on Apr 23 2019, 10:55 PM.

Details

Summary

KFileMetaData is not a required dependency to allow build for Android where it is not needed to get data for music files

fix Windows KDE CI build by removing include for KFileMetaData headers
from filescanner.h

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Apr 23 2019, 10:55 PM
mgallien created this revision.
astippich accepted this revision.Apr 24 2019, 5:44 AM

Oops, sorry, forgot about that. I noticed that I made more mistakes here. Do you want to change them while you are at it? Otherwise, I will change them afterwards. See inline comments

src/filescanner.cpp
148

inverted condition, and also below for composer and lyricist

This revision is now accepted and ready to land.Apr 24 2019, 5:44 AM

Oops, sorry, forgot about that. I noticed that I made more mistakes here. Do you want to change them while you are at it? Otherwise, I will change them afterwards. See inline comments

You can push a fix directly without going through a review if it is targeted only to that.
We should have soon coverage by the KDE CI for the stable branches which should help detect more issues and sooner.

This revision was automatically updated to reflect the committed changes.