KFileMetaData is not a required dependency to allow build for Android where it is not needed to get data for music files
fix Windows KDE CI build by removing include for KFileMetaData headers
from filescanner.h
KFileMetaData is not a required dependency to allow build for Android where it is not needed to get data for music files
fix Windows KDE CI build by removing include for KFileMetaData headers
from filescanner.h
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Oops, sorry, forgot about that. I noticed that I made more mistakes here. Do you want to change them while you are at it? Otherwise, I will change them afterwards. See inline comments
src/filescanner.cpp | ||
---|---|---|
148 | inverted condition, and also below for composer and lyricist |
You can push a fix directly without going through a review if it is targeted only to that.
We should have soon coverage by the KDE CI for the stable branches which should help detect more issues and sooner.