Differential D20775

file import: do not use overwritten temorary file
ClosedPublic
Actions

Authored by tklausmann on Apr 23 2019, 8:45 PM.

Details

Reviewers
habacker
Group Reviewers
Umbrello
Commits
R139:04580cac31b1: file import: do not use overwritten temporary file
Summary

We checked if the temporary file we created still exists after its creation,
yet in the meantime we have already copied to it (which overwrites it):
KIO::FileCopyJob *job = KIO::file_copy(url, dest, -1, KIO::Overwrite);

Instead of the temporary file, check if the regular file we use later on exists.

Bug: 406574

Diff Detail

Repository
R139 Umbrello
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tklausmann created this revision.Apr 23 2019, 8:45 PM
Restricted Application added a project: Umbrello. · View Herald TranscriptApr 23 2019, 8:45 PM
Restricted Application added a subscriber: umbrello-devel. · View Herald Transcript
tklausmann requested review of this revision.Apr 23 2019, 8:45 PM
habacker accepted this revision.Apr 27 2019, 1:12 AM
This revision is now accepted and ready to land.Apr 27 2019, 1:12 AM
Closed by commit R139:04580cac31b1: file import: do not use overwritten temporary file (authored by habacker). · Explain WhyApr 27 2019, 1:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mumbrello/umldoc.cpp (8 lines)

Diff 57078

View Options

umbrello/umldoc.cpp

Loading...