Differential D20773

[Task Manager] Bring to current desktop with middle-click
ClosedPublic
Actions

Authored by thsurrel on Apr 23 2019, 7:47 PM.

Details

Reviewers

hein

Group Reviewers

Plasma

Commits

R119:a416f16b562b: [Task Manager] Bring to current desktop with middle-click

Summary

This adds a new possible action when middle-click is used on a task
in the task manager: bringing that task to the current desktop.

FEATURE: 360250

Test Plan

In the task manager settings > Behavior > On middle-click, select
'Bring to the current desktop', and make sure 'Show only tasks from
the current desktop' is deselected.
Having several applications opened on different virtual desktops,
middle-click on a task from another desktop and check that it is
brought to the current one.

Diff Detail

Repository

R119 Plasma Desktop

Branch

arc_middleclick

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11170
Build 11188: arc lint + arc unit

thsurrel created this revision.Apr 23 2019, 7:47 PM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2019, 7:47 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

thsurrel requested review of this revision.Apr 23 2019, 7:47 PM

Harbormaster completed remote builds in B11161: Diff 56842.Apr 23 2019, 7:47 PM

ngraham added a subscriber: ngraham.Apr 23 2019, 7:54 PM

ngraham added inline comments.

applets/taskmanager/package/contents/ui/ConfigBehavior.qml
116	Maybe "virtual desktop" instead of just "desktop"?
applets/taskmanager/plugin/backend.h
55	Indentation

Fixes as per Nate's comments.
Thanks for the review!

Harbormaster completed remote builds in B11170: Diff 56865.Apr 24 2019, 7:24 AM

thsurrel marked 2 inline comments as done.Apr 24 2019, 7:24 AM

hein accepted this revision.Apr 24 2019, 8:18 AM

This revision is now accepted and ready to land.Apr 24 2019, 8:18 AM

Closed by commit R119:a416f16b562b: [Task Manager] Bring to current desktop with middle-click (authored by thsurrel). · Explain WhyApr 24 2019, 9:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/taskmanager/package/contents/config/main.xml (1 line)
M			applets/taskmanager/package/contents/ui/ConfigBehavior.qml (3 lines)
M			applets/taskmanager/package/contents/ui/Task.qml (2 lines)
M			applets/taskmanager/plugin/backend.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56842	2e2cfa8		Apr 23 2019, 7:47 PM	★	★
Diff 2	56865	2e2cfa8	Fixes as per Nate's comments.	Apr 24 2019, 7:24 AM	★	★
Diff 3	56875	2e2cfa8	R119:a416f16b562b8eca364c38c7bb99f21bb1996c01	Apr 24 2019, 9:13 AM	★	★