Avoid copying key variable in the loop, as warned by QtCreator
ClosedPublic

Authored by meven on Tue, Apr 23, 1:39 PM.

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Tue, Apr 23, 1:39 PM
Restricted Application added a project: Baloo. · View Herald TranscriptTue, Apr 23, 1:39 PM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
meven requested review of this revision.Tue, Apr 23, 1:39 PM
meven updated this revision to Diff 56820.Tue, Apr 23, 1:43 PM

Use auto& instead of QString&

meven added a reviewer: bruns.Tue, Apr 23, 1:43 PM
bruns requested changes to this revision.Fri, May 3, 12:41 AM
bruns added inline comments.
src/filemetadatawidget.cpp
179

for (const auto& key : keys) {

This revision now requires changes to proceed.Fri, May 3, 12:41 AM
meven updated this revision to Diff 57439.Fri, May 3, 7:47 AM

Add a sp

meven marked an inline comment as done.Fri, May 3, 7:47 AM
ngraham accepted this revision.Fri, May 3, 1:35 PM
bruns accepted this revision.Fri, May 3, 6:14 PM
This revision is now accepted and ready to land.Fri, May 3, 6:14 PM
This revision was automatically updated to reflect the committed changes.