Move most of UnencryptedMessageTest tests to MimeTreeParser.
ClosedPublic

Authored by knauss on Mon, Apr 22, 8:48 PM.

Details

Summary

As most of those tests in UnencryptedMessageTest do not need anything from
MessageViewer we should move them to MimeTreeParser in order to find
those easier. Some smaller syntactical updates are done.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.Mon, Apr 22, 8:48 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMon, Apr 22, 8:48 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss requested review of this revision.Mon, Apr 22, 8:48 PM
mlaurent requested changes to this revision.Tue, Apr 23, 4:55 AM
mlaurent added a subscriber: mlaurent.

"Move tests from MessageViewer to MimeTreeParser." it's a moving or a copying ?
It seems that it's a copying no ?
Perhaps it's needed to change title

This revision now requires changes to proceed.Tue, Apr 23, 4:55 AM
knauss updated this revision to Diff 56819.Tue, Apr 23, 1:41 PM

update description.

This is git logic, that it defines this as a copy. And I think git it more or less right, as we can't move every tests because some tests need MessageViewer::BufferedHtmlWriter. Only

	​    testNotDecrypted_data();
	​    testNotDecrypted();
	​    testSMimeAutoCertImport();

are kept in unencryptedmessagetest. Look how much of the original unencryptedmessagetest is removed with this copy to see, that I do a move.

knauss retitled this revision from Move tests from MessageViewer to MimeTreeParser. to Move most of UnencryptedMessageTest tests to MimeTreeParser..Tue, Apr 23, 1:42 PM
knauss edited the summary of this revision. (Show Details)
mlaurent accepted this revision.Wed, Apr 24, 6:51 AM
This revision is now accepted and ready to land.Wed, Apr 24, 6:51 AM
This revision was automatically updated to reflect the committed changes.