Differential D20747

[FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI
ClosedPublic
Actions

Authored by ngraham on Apr 22 2019, 8:28 PM.

Details

Reviewers
GB_2
filipf
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R114:ad8f253d8c76: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and…
Summary
  • Port to QQC2 and Kirigami+FormLayout
  • Use radio buttons to choose color vs image
  • Disable inactive controls appropriately
Test Plan

Everything still works.

Diff Detail

Repository
R114 Plasma Addons
Branch
modernize-fifteenpuzzle-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11188
Build 11206: arc lint + arc unit
ngraham created this revision.Apr 22 2019, 8:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 22 2019, 8:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 22 2019, 8:28 PM
ngraham retitled this revision from [FifteenPuzzle] Modernize settings window to [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout.Apr 22 2019, 8:35 PM
ngraham edited the summary of this revision. (Show Details)
filipf added a subscriber: filipf.Apr 23 2019, 12:05 PM
filipf added inline comments.
applets/fifteenPuzzle/package/contents/ui/configAppearance.qml
71–74

You could have enabled: !useImageCheckBox.checked here

84

And then enabled: showNumeralsCheckBox.checked here

ngraham updated this revision to Diff 56840.Apr 23 2019, 7:22 PM
ngraham marked 2 inline comments as done.

Improve it even more (hopefully)

ngraham edited the summary of this revision. (Show Details)Apr 23 2019, 7:23 PM
ngraham edited the test plan for this revision. (Show Details)
GB_2 added a subscriber: GB_2.Apr 23 2019, 8:09 PM
GB_2 added inline comments.
applets/fifteenPuzzle/package/contents/ui/configAppearance.qml
136

You could make it like this:
Tiles: [ ] Colored numbers: [ Button ]

filipf added a comment.Apr 23 2019, 8:42 PM

Tried it out, looks good and is efficient.

One behavior thing though, I'm not getting any background option that's being defaulted to:

The "Color" option is not being remembered either (the color itself is, but not that you're using that option).

ngraham planned changes to this revision.Apr 23 2019, 8:44 PM

Oh, duh.

ngraham updated this revision to Diff 56919.Apr 24 2019, 8:37 PM

Remember checked state for Color radio button

ngraham updated this revision to Diff 56920.Apr 24 2019, 8:39 PM
ngraham marked an inline comment as done.

Tweak UI according to review comments

ngraham edited the test plan for this revision. (Show Details)Apr 24 2019, 8:40 PM
ngraham retitled this revision from [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout to [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI.
ngraham edited the summary of this revision. (Show Details)
GB_2 accepted this revision as: VDG, GB_2.Apr 24 2019, 8:42 PM
This revision is now accepted and ready to land.Apr 24 2019, 8:42 PM
filipf accepted this revision.Apr 24 2019, 8:44 PM
Closed by commit R114:ad8f253d8c76: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and… (authored by ngraham). · Explain WhyApr 24 2019, 8:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56919

View Options

applets/fifteenPuzzle/package/contents/ui/configAppearance.qml

Loading...