Remove disable for showing only minimized tasks on Icons only task manager
Needs ReviewPublic

Authored by cblack on Apr 22 2019, 8:26 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
VDG
Summary

This patch removes the visible: property that hides the option to show only tasks that are minimized to users of the icons only task manager

Test Plan

Make sure that the icons only task manager behaves as expected when showing only minimized tasks

Diff Detail

Repository
R119 Plasma Desktop
Branch
minimized-only (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11121
Build 11139: arc lint + arc unit
cblack created this revision.Apr 22 2019, 8:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 22 2019, 8:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 22 2019, 8:26 PM

The original code is pretty clear, this isn't just a bugfix over what the author originally intended, so we need to understand that first.

Git logs didn't tell me enough detail why it's there. It was added pretty early on with a tonne of other code.
@hein can you shed some light?

ndavis added a subscriber: ndavis.EditedTue, Apr 23, 4:48 PM

Edit: looks like I'm 10 minutes late

@hein You appear to have been the one who created the first version of this line, but I can't figure out why it was added.

This is the commit where it was added:

commit 3b84f96dc32b60e45127b8d3011ffff1ac232f9e
Author: Eike Hein <hein@kde.org>
Date:   Fri Sep 5 22:07:01 2014 +0200

    Initial commit of Icons-only Task Manager applet.
---
 applets/taskmanager/package/contents/ui/ConfigGeneral.qml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/applets/taskmanager/package/contents/ui/ConfigGeneral.qml b/applets/taskmanager/package/contents/ui/ConfigGeneral.qml
index c4770aad..18243f6b 100644
--- a/applets/taskmanager/package/contents/ui/ConfigGeneral.qml
+++ b/applets/taskmanager/package/contents/ui/ConfigGeneral.qml
@@ -70,6 +70,8 @@ ColumnLayout {
         title: i18n("Grouping and Sorting")
         flat: true

+        visible: (plasmoid.pluginName != "org.kde.plasma.icontasks")
+
         ColumnLayout {
             RowLayout {
                 Label {
@@ -110,6 +112,8 @@ ColumnLayout {
         title: i18n("Filters")
         flat: true

+        Layout.fillHeight: true
+
         ColumnLayout {
             CheckBox {
                 id: showOnlyCurrentScreen
@@ -128,6 +132,9 @@ ColumnLayout {

             CheckBox {
                 id: showOnlyMinimized
+
+                visible: (plasmoid.pluginName != "org.kde.plasma.icontasks")
+
                 text: i18n("Show only tasks that are minimized")
             }
         }
ngraham added a subscriber: ngraham.

The Icons-only task manager show apps, not windows/tasks. Apps don't get minimized; windows/tasks do. So I'm guessing that this feature isn't exposed in the IOTM because it conceptually doesn't make any sense given the IOTM's UX ("Show apps, not windows/tasks").

Can you describe what it is that makes you want this functionality in the IOTM rather than just using the regular task manager and enabling this feature?

-snip-
Can you describe what it is that makes you want this functionality in the IOTM rather than just using the regular task manager and enabling this feature?

The regular task manager is often redundant in the information it gives - the icon alone is often enough to tell what type of task is being performed. If I see an icon for an IDE, that is going to tell me that I've been doing some programming with that application. The only applications that a name would
have a large benefit in distinguishing between current tasks would be the web browser and the terminal emulator. The name also often describes what can be seen within a few seconds of pulling up the window or looking at the preview in some cases.

It's also a stylistic thing, as not displaying window name/application name is "modern".

But what happens if you have an app pinned and minimize its window? Then the app will always show regardless of whether it's minimized or not.
On the other hand, we have the same issue for windows from the same activity or desktop, so I don't see why this particular filtering case should be any worse/different than the others.