According to specification sizes is a space-separated list of sizes which are separated by x or X.
Also, try to find a thumbnail closest to 512x512 to avoid loading huge thumbnails.
Details
Details
master
No longer tries to load a Full HD YouTube thumbnail here anymore
Still works when there's just one image with a size
Still works when there's just one image without a size
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Lint Skipped - Unit
Unit Tests Skipped
host/mprisplugin.cpp | ||
---|---|---|
476–477 | AFAICT this will not work as expected in cases such as 1920x1080 followed by 256x256. |
host/mprisplugin.cpp | ||
---|---|---|
489 | Why change this line? With auto it was easier to read, just the & should be removed for clarity. Now it also accepts `xx42xx42xx" as valid size, while it didn't before. | |
498 | That's still equal to std::numeric_limits<qreal>::max() due to lacking precision. | |
510 | This algorithm only looks at the aspect ratio of the image, not the resolution. For 4096x4096, 1024x1024 and 512x512 you'll get the same effectiveSamples value, so it will load huge thumbnails again. |