Fix No such slot KPIM::TagSelectionCombo::updateCheckedItems
AbandonedPublic

Authored by ognarb on Apr 22 2019, 11:51 AM.

Details

Reviewers
None
Group Reviewers
KDE PIM
Summary

The error was QObject::connect: No such slot KPIM::TagSelectionCombo::
updateCheckedItems(QModelIndex,QModelIndex) when

I think this is caused by: R89:2c401cf641fbb03e5a9780417717c8d072499aa4.

Not sure if this is the right fix: making a private method public.

Test Plan

Build and run. The error message isn't diplayed anumore.

Diff Detail

Repository
R89 PIM: Libraries
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11100
Build 11118: arc lint + arc unit
ognarb created this revision.Apr 22 2019, 11:51 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2019, 11:51 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ognarb requested review of this revision.Apr 22 2019, 11:51 AM
ognarb updated this revision to Diff 56734.Apr 22 2019, 11:52 AM

Improve doc

dvratil added inline comments.
src/libkdepim/widgets/kcheckcombobox.h
161

Maybe move it to the public Q_SLOTS section as well?

Hi,
Did you test on korganizer if it works ?
Here when you try to select a tag it crashs.

Regards.

ognarb abandoned this revision.Thu, May 9, 9:01 AM

I don't find a way to reproduce the error `QObject::connect: No such slot KPIM::TagSelectionCombo::
updateCheckedItems(QModelIndex,QModelIndex)`. I will reopen this revision, if I found a way.