Add an assert as a regression test.
ClosedPublic

Authored by shlomif on Apr 22 2019, 11:34 AM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Summary

I hereby disclaim any implicit or explicit ownership of my changes in this
changeset, and put them under a multiple licence consisting of your choice of
one of more of:

  • The default licence of your project

2.1 or higher

higher

  • Any licence in the 2018-Aug-27 popular licenses list of

https://opensource.org/licenses

Crediting me will be nice, but not mandatory, and you can change the licence
of the project without needing my permission.

Diff Detail

Repository
R410 KPatience
Branch
bug406587-freecell-autodrop
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11096
Build 11114: arc lint + arc unit
shlomif created this revision.Apr 22 2019, 11:34 AM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptApr 22 2019, 11:34 AM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
shlomif requested review of this revision.Apr 22 2019, 11:34 AM
aacid accepted this revision.Apr 24 2019, 9:24 PM
aacid added a subscriber: aacid.

not sure assert really counts as a test, but better than nothing i guess :D

For future thought, do you think it looks nicer having the test code inside the CMakeLists.txt as in https://cgit.kde.org/okular.git/tree/generators/poppler/CMakeLists.txt#n43 ?

This way people won't get confused as why there's such a simple .c files on the root folder

This revision is now accepted and ready to land.Apr 24 2019, 9:24 PM
shlomif closed this revision.Jun 1 2019, 12:24 PM

Merged, thanks,