Differential D20721

Optimize loading freecell games.
ClosedPublic
Actions

Authored by shlomif on Apr 21 2019, 8:52 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R410:3d9e8324d505: Add a comment to explain.
R410:1aaa543eb25a: Optimize loading freecell games.
Summary

See https://bugs.kde.org/show_bug.cgi?id=406587 . There were excessive
calls to libfreecell-solver.

Test Plan

Test loading of Freecell and Simple Simon games

Diff Detail

Repository
R410 KPatience
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shlomif created this revision.Apr 21 2019, 8:52 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptApr 21 2019, 8:52 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
shlomif requested review of this revision.Apr 21 2019, 8:52 PM
aacid added a subscriber: aacid.Apr 21 2019, 10:47 PM

Can you explain the reason this optimizes things (ideally in the commit log)?

To an external eye it seems that a "small number of positions" would be "the easy" thing to solve instead of the hard one that needs to be shortcutted out

shlomif updated this revision to Diff 56714.Apr 22 2019, 9:46 AM
  • Add a comment to explain.
aacid accepted this revision.Apr 22 2019, 10:19 AM
This revision is now accepted and ready to land.Apr 22 2019, 10:19 AM
Closed by commit R410:1aaa543eb25a: Optimize loading freecell games. (authored by shlomif). · Explain WhyApr 22 2019, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56723

View Options

patsolve/abstract_fc_solve_solver.cpp

Loading...