Change input-* device icon styles, add 16px icons
ClosedPublic

Authored by ndavis on Sun, Apr 21, 1:12 PM.

Details

Summary

devices/16 was missing some input-* icons.
input-keyboard-virtual looked more like a wireless keyboard than a virtual keyboard.
Changed input-keyboard* style so that it could appear consistent at 16 and 22px. It also looks a bit more like a real keyboard.
Made dialog-input-devices more similar to the hicolor symbolic version for Inkscape (mouse and tablet)
Made configure-shortcuts icon look good at 16px.

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Sun, Apr 21, 1:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Apr 21, 1:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Sun, Apr 21, 1:12 PM
ndavis edited the summary of this revision. (Show Details)Sun, Apr 21, 1:17 PM
ndavis edited the test plan for this revision. (Show Details)

Overall very nice.

Instead of symlinking input-mouse to dialog-input-devices, I think it might make more sense to rename dialog-input-devices to be input-mouse and then change the dialog-input-devices so that it depicts more than one input device, to reinforce its name. Maybe a mouse + keyboard?

While you're thinking about input device icons, we also have a few outstanding bugs:

Overall very nice.

Instead of symlinking input-mouse to dialog-input-devices, I think it might make more sense to rename dialog-input-devices to be input-mouse and then change the dialog-input-devices so that it depicts more than one input device, to reinforce its name. Maybe a mouse + keyboard?

I don't think I can fit a whole keyboard, but I can probably fit a numpad.

While you're thinking about input device icons, we also have a few outstanding bugs:

  • The colorful version of the mouse icon is hard to see on a dark background, and also it maybe should have a more generic appearance rather than looking like a Razer mouse: https://bugs.kde.org/show_bug.cgi?id=406453

That will be a lot of work and I don't want to do that in this diff since it'll slow the rest of the changes down considerably. The most important change in this diff is that this is fixed (22px icon where 16px should be):

I'll do that with the 64px mouse icon fix when I get around to it.

ndavis added a comment.EditedMon, Apr 22, 2:26 AM

Actually, dialog-input-devices is used by inkscape for configuring pointing devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show more types of devices, it would be more accurate to use a tablet. Looking at the Input Devices dock in Inkscape, it doesn't seem like it would be used much for configuring mice, so it might be better if it was just a symlink to the input-tablet icon.

These are the hicolor icons Inkscape uses for that icon:

Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because in principle any app could use it. It's more important for the icon to be semantically correct for any app that wants to use it than it is for it to match its current sole user.

For dialog-input-devices, I would accept an icon that includes a drawing tablet, but not one that has only a drawing tablet.

We can do the Mouse and Joystick changes in another patch, I just wanted to mention them. :)

Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because in principle any app could use it. It's more important for the icon to be semantically correct for any app that wants to use it than it is for it to match its current sole user.

For dialog-input-devices, I would accept an icon that includes a drawing tablet, but not one that has only a drawing tablet.

How is this? 16px

I tried making the mouse bigger, but it didn't work out very well since there was never quite enough room to make it feel balanced.

I think that looks good!

ndavis updated this revision to Diff 58047.Tue, May 14, 6:38 AM

Add new dialog-input-devices icons

ndavis edited the summary of this revision. (Show Details)Tue, May 14, 6:43 AM
ndavis edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Wed, May 15, 4:05 PM
This revision is now accepted and ready to land.Wed, May 15, 4:05 PM
This revision was automatically updated to reflect the committed changes.