Fix corner screen glows that suddenly pop up
ClosedPublic

Authored by zzag on Apr 21 2019, 12:22 PM.

Details

Summary

Depending on how pointer approaches a screen corner, the maximum
distance between two may be smaller than 2 * edgeDistance. This can
happen for example when approaching the corner along of any two adjacent
screen edges.

As a result, the calculated factor can be anywhere between 0 and 0.5
when pointer enters approachGeometry(). This change adjusts calculation
of the factor, so it always ranges from 0 to 1 no matter how the pointer
approaches corners.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Apr 21 2019, 12:22 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 21 2019, 12:22 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Apr 21 2019, 12:22 PM
zzag added a comment.Apr 21 2019, 12:22 PM

math details

davidedmundson accepted this revision.Apr 23 2019, 4:04 PM
This revision is now accepted and ready to land.Apr 23 2019, 4:04 PM
This revision was automatically updated to reflect the committed changes.