BUG: 368587, Fix minimal shade selection

Authored by vanyossi on Apr 19 2019, 7:31 AM.


Group Reviewers

Adds: missing events for selecting minimal Shade

Changed: Used last slot to show preview of spinner settings. clicking on the edited gradient/patches will set that as mnimal shade selector

Diff Detail

R37 Krita
Lint Skipped
Unit Tests Skipped
vanyossi created this revision.Apr 19 2019, 7:31 AM
Restricted Application added a reviewer: Krita. ยท View Herald TranscriptApr 19 2019, 7:31 AM
vanyossi requested review of this revision.Apr 19 2019, 7:31 AM

Well, I couldn't reproduce the problem before the patch. And neither I could reproduce it after the patch. At least it doesn't do any regressions :)

The only problem it doesn't address (not in the original report, but still might be related:

  1. Press "Reset to Defaults" button in the bottom-left corner
  2. [BUG] Observe that the sliders haven't updated
  3. Hover over the slider with a mouse, see how the sliders' gradients have updates and show correct values.

I'm not sure how related it is though

vanyossi abandoned this revision.Apr 26 2019, 5:06 PM

task moved to gitlab and merged