Fix compile on arm
ClosedPublic
Actions

Authored by aacid on Apr 18 2019, 11:06 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Don't ask me why but the defines are giving an ultra weird warning

src/kbkglobal.h:59:26: error: expected ‘,’ or ‘...’ before numeric constant
#define minZ 1.0 // Nearest point represented in the view.

And the #include "kbkglobal.h" is needed so glColor3f is defined via the includes there

Repository

R419 Kubrick

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript

aacid requested review of this revision.Apr 18 2019, 11:06 PM

LGTM, anothher fix could have been wrapping them with parenthesis?

This revision is now accepted and ready to land.Apr 19 2019, 11:44 PM

This revision was automatically updated to reflect the committed changes.

In D20677#453140, @apol wrote:

LGTM, anothher fix could have been wrapping them with parenthesis?

Honestly i don't know, still think an actual variable definition is better

			Path	Packages
M			src/kbkglobal.h (4 lines)
M			src/scenelabel.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56571	3a71a2a		Apr 18 2019, 11:06 PM	★	★
Diff 2	56617	03a5abb	R419:2ab1d007cefb2870e871ac38c8999ee9f400edfb	Apr 20 2019, 10:08 AM	★	★