Differential D20675

LoadingPage: Use Kirigami.Heading
ClosedPublic
Actions

Authored by jbbgameich on Apr 18 2019, 9:40 PM.

Details

Reviewers
ngraham
Group Reviewers
Discover Software Store
Commits
R134:f061345ad6fe: LoadingPage: Use Kirigami.Heading
Summary

Unifies the look of the loading message with the other messages in discover.

Test Plan

Font size is correct when installing a package e.g from a flatpak ref.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jbbgameich created this revision.Apr 18 2019, 9:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 18 2019, 9:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jbbgameich requested review of this revision.Apr 18 2019, 9:40 PM
ngraham accepted this revision.Apr 18 2019, 10:08 PM
ngraham added a subscriber: ngraham.

And we also need to give this page a spinner, just like the Updates page has.

This revision is now accepted and ready to land.Apr 18 2019, 10:08 PM
Closed by commit R134:f061345ad6fe: LoadingPage: Use Kirigami.Heading (authored by jbbgameich). · Explain WhyApr 18 2019, 10:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/LoadingPage.qml (4 lines)

Diff 56568

View Options

discover/qml/LoadingPage.qml

Loading...