Add an icon for Thunderbolt KCM
ClosedPublic

Authored by yurchor on Apr 18 2019, 6:46 PM.

Details

Summary

An icon for D19011

Test Plan

PNG version:

Diff Detail

Repository
R266 Breeze Icons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11011
Build 11029: arc lint + arc unit
yurchor created this revision.Apr 18 2019, 6:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 18 2019, 6:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
yurchor requested review of this revision.Apr 18 2019, 6:46 PM
yurchor edited the test plan for this revision. (Show Details)Apr 18 2019, 6:50 PM
ngraham added a reviewer: VDG.Apr 18 2019, 6:51 PM

Thanks! Generally we use colorful icons for KCMs. I think this could use a bit more pizazz. :) Maybe make it yellow, and/or put it on top of a circular colored background or something?

yurchor updated this revision to Diff 56556.Apr 18 2019, 7:19 PM

Use the official blue background

yurchor edited the test plan for this revision. (Show Details)Apr 18 2019, 7:20 PM

Ooh, I like that! Maybe make the thunderbolt a bit smaller inside the circle though?

Also, the circle itself is slightly larger than other circle-background KCM icons and needs to be a tiny bit smaller. You can use preferences-desktop-font as a model for how big the circle should be.

In general here are the colorful icon design guidelines: https://hig.kde.org/style/icon.html#colorful-icon-style

yurchor updated this revision to Diff 56559.Apr 18 2019, 8:03 PM

Smaller, add gradient

yurchor edited the test plan for this revision. (Show Details)Apr 18 2019, 8:04 PM

Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle.

filipf added a subscriber: filipf.Apr 18 2019, 9:02 PM

Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle.

+1

yurchor updated this revision to Diff 56576.Apr 19 2019, 3:19 AM

Darker top

yurchor edited the test plan for this revision. (Show Details)Apr 19 2019, 3:20 AM

+1. @ndavis, @GB_2, or @filipf, any thoughts on this version?

ndavis requested changes to this revision.Apr 19 2019, 11:12 AM

A few problems:

  1. That circle has a diameter of 27.9px instead of 28px
  2. There is no copy of the icon in icons-dark/preferences/32/
  3. The top of the gradient is transparent, which leads to issues like this:

The lightning bolt is not aligned to the pixel grid, but it's really not that bad at 100% size. TBH, I don't think it's worth the effort required to align it.

This revision now requires changes to proceed.Apr 19 2019, 11:12 AM
yurchor updated this revision to Diff 56590.Apr 19 2019, 12:25 PM
  1. Fix diameter.
  2. Add copy for dark.
  3. Use non-transparent gradient.
yurchor edited the test plan for this revision. (Show Details)Apr 19 2019, 12:26 PM
ngraham accepted this revision as: ngraham.Apr 19 2019, 2:36 PM

Wow, that's quite beautiful. Thumbs up from me now!

ndavis accepted this revision.Apr 19 2019, 2:40 PM

I like the new top color.

This revision is now accepted and ready to land.Apr 19 2019, 2:40 PM
ndavis requested changes to this revision.Apr 19 2019, 2:44 PM

Actually, one last thing. Can you save it as a plain SVG so that it isn't filled with Inkscape metadata?

This revision now requires changes to proceed.Apr 19 2019, 2:44 PM
yurchor updated this revision to Diff 56598.Apr 19 2019, 2:48 PM

Use plain SVG

abetts added a subscriber: abetts.Apr 19 2019, 2:51 PM

Sorry for coming this late into the conversation. I was wondering if the spear in the bolt can be changed to be horizontal? It would be more visually consistent with the angle that the lightning bold is. The back of the arrow |>, that needs to be horizontal.

Sorry for coming this late into the conversation. I was wondering if the spear in the bolt can be changed to be horizontal? It would be more visually consistent with the angle that the lightning bold is. The back of the arrow |>, that needs to be horizontal.

Initially, that was repainted official designation of Thunderbolt connectors:

https://upload.wikimedia.org/wikipedia/commons/a/a8/Thunderbolt_Connertor.jpg

Thunderbolt official logo:

https://upload.wikimedia.org/wikipedia/commons/6/67/Thunderbolt.svg

ndavis accepted this revision.Apr 19 2019, 3:14 PM
This revision is now accepted and ready to land.Apr 19 2019, 3:14 PM
This revision was automatically updated to reflect the committed changes.