Differential D20664

Fix adding "Create New..." menu to toolbar
ClosedPublic
Actions

Authored by ngraham on Apr 18 2019, 1:46 PM.

Details

Reviewers
elvisangelaccio
broulik
cfeck
Group Reviewers
Dolphin
Commits
R318:48c082767e31: Fix adding "Create New..." menu to toolbar
Summary

Access the object by its existing name rather than renaming it.

BUG: 405780
FIXED-IN: 19.04.1

Test Plan
  • Add Create New item to toolbar; it now works
  • Verify that Create New menu and toolbar items are disabled when in the trash
  • All tests still pass

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 18 2019, 1:46 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 18 2019, 1:46 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 18 2019, 1:46 PM
cfeck accepted this revision.Apr 18 2019, 7:14 PM
cfeck added a subscriber: cfeck.

Thanks for the investigation!

This revision is now accepted and ready to land.Apr 18 2019, 7:14 PM
Closed by commit R318:48c082767e31: Fix adding "Create New..." menu to toolbar (authored by ngraham). · Explain WhyApr 18 2019, 7:17 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a comment.Apr 20 2019, 10:32 AM

Good catch, sorry for breaking it ;)

Revision Contents
Changeset List

Diff 56555

View Options

src/dolphinmainwindow.cpp

Loading...
View Options

src/tests/dolphinmainwindowtest.cpp

Loading...