Differential D20663

Use more accurate name for Workspace::getMovingClient method
ClosedPublic
Actions

Authored by zzag on Apr 18 2019, 1:23 PM.

Details

Reviewers

apol

Group Reviewers

KWin

Commits

R108:abe128818cf3: Use more accurate name for Workspace::getMovingClient method

Summary

The name of Workspace::getMovingClient() method implies that the
returned value is a client that is currently being moved around
by the user, but this is of course incorrect.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Apr 18 2019, 1:23 PM

Restricted Application added a project: KWin. · View Herald TranscriptApr 18 2019, 1:23 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Apr 18 2019, 1:23 PM

Harbormaster completed remote builds in B10995: Diff 56526.Apr 18 2019, 1:23 PM

Reads better!

This revision is now accepted and ready to land.Apr 19 2019, 11:36 PM

Closed by commit R108:abe128818cf3: Use more accurate name for Workspace::getMovingClient method (authored by zzag). · Explain WhyApr 22 2019, 8:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.cpp (2 lines)
M			autotests/integration/effects/wobbly_shade_test.cpp (4 lines)
M			autotests/integration/lockscreen.cpp (6 lines)
M			autotests/integration/move_resize_window_test.cpp (40 lines)
M			autotests/integration/quick_tiling_test.cpp (16 lines)
M			autotests/integration/struts_test.cpp (4 lines)
M			autotests/mock_workspace.h (6 lines)
M			autotests/mock_workspace.cpp (10 lines)
M			autotests/test_screen_edges.cpp (4 lines)
M			geometry.cpp (6 lines)
M			input.cpp (12 lines)
M			moving_client_x11_filter.cpp (2 lines)
M			pointer_input.cpp (6 lines)
M			screenedge.cpp (6 lines)
M			useractions.cpp (8 lines)
M			workspace.h (11 lines)