Differential D20662

Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set
ClosedPublic
Actions

Authored by heikobecker on Apr 18 2019, 1:08 PM.

Details

Reviewers
kossebau
dfaure
Commits
R467:eb117b98a107: Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set
Summary

With the newer ECM requirement introduced in [1]
CMAKE_RUNTIME_OUTPUT_DIRECTORY gets set [2], which causes the tests
to fail because they don't find the test executables. Adding the
NAME and COMMAND keywords, which aren't really optional according to
cmake's docs, makes them pass again.

[1] cb9697bc1a5ee2b31d554d6ae68c9c6e12206eea
[2] https://phabricator.kde.org/D7198

Diff Detail

Repository
R467 K3b
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker requested review of this revision.Apr 18 2019, 1:08 PM
heikobecker created this revision.
kossebau accepted this revision.Apr 18 2019, 1:16 PM

My bad, I know about this need for the newer add_test signature, but seems somehow missed it here. Thanks for fixing.

This revision is now accepted and ready to land.Apr 18 2019, 1:16 PM
heikobecker updated this revision to Diff 56523.Apr 18 2019, 1:16 PM

Fixed the commit which introduced the newer ECM requirement

Closed by commit R467:eb117b98a107: Fix running the tests with CMAKE_RUNTIME_OUTPUT_DIRECTORY set (authored by heikobecker). · Explain WhyApr 18 2019, 1:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/CMakeLists.txt (12 lines)

Diff 56525

View Options

tests/CMakeLists.txt

Loading...