Differential D20661

[MPRIS Data Engine] Avoid blocking calls when changing volume
ClosedPublic
Actions

Authored by broulik on Apr 18 2019, 12:46 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:9b24060c632e: [MPRIS Data Engine] Avoid blocking calls when changing volume
Summary

Avoids plasmashell freezing when the player app is unresponsive or has a broken MPRIS implementation

Test Plan

kill -SIGSTOP pidof vlc`, wheeled the tray icon, plasmashell didn't freeze anymore.
Quickly changing volume still works (hence setting the new value in the dataengine right away)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 18 2019, 12:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 18 2019, 12:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 18 2019, 12:46 PM
davidedmundson accepted this revision.Apr 18 2019, 1:01 PM
This revision is now accepted and ready to land.Apr 18 2019, 1:01 PM
Closed by commit R120:9b24060c632e: [MPRIS Data Engine] Avoid blocking calls when changing volume (authored by broulik). · Explain WhyApr 18 2019, 1:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdataengines/mpris2/playercontrol.cpp (63 lines)

Diff 56528

View Options

dataengines/mpris2/playercontrol.cpp

Loading...