Fix missing update of file name label in information panel without preview
ClosedPublic

Authored by bruns on Apr 18 2019, 12:41 PM.

Details

Summary

The file name label was only updated when the preview was shown, after
the function was moved into a conditional section. This is a regression
caused by commit 405aa4878f75 ("[InformationPanel] Hide the video when the
preview is disabled, avoid computing the preview when it is disabled").

Test Plan

Hide the preview in dolphin's information panel
Hover different files, the name label reflects the hovered file again

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 18 2019, 12:41 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 18 2019, 12:41 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
bruns requested review of this revision.Apr 18 2019, 12:41 PM
meven accepted this revision.Apr 18 2019, 1:25 PM

Good catch, thanks

This revision is now accepted and ready to land.Apr 18 2019, 1:25 PM
This revision was automatically updated to reflect the committed changes.

The stable branch was also affected, I cherry-picked the fix.