Differential D2065

Provide qmake arguments via list.
ClosedPublic
Actions

Authored by cordlandwehr on Jul 2 2016, 4:05 PM.

Details

Reviewers
apol
kfunk
Group Reviewers
KDevelop
Commits
R32:4650682b0eff: Provide qmake arguments via list.
Summary

Provide QProcess arguments as specified by documentation. Apparently,
with Qt 5.6 QProcess stopped to accept the previously used single string
argument. This fixes detection of the system's qthelp documentation for
Qt.

Test Plan

Manual testing.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr updated this revision to Diff 4903.Jul 2 2016, 4:05 PM
cordlandwehr retitled this revision from to Provide qmake arguments via list..
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 2 2016, 4:05 PM
apol accepted this revision.Jul 2 2016, 4:13 PM
apol added a reviewer: apol.
apol added a subscriber: apol.
apol added inline comments.
documentation/qthelp/qthelpqtdoc.cpp
64

Note you can use initializer lists: { "a", "b" }

This revision is now accepted and ready to land.Jul 2 2016, 4:13 PM
cordlandwehr updated this revision to Diff 4904.Jul 2 2016, 4:17 PM
cordlandwehr edited edge metadata.
  • Use initializer lists.
apol added inline comments.Jul 2 2016, 4:19 PM
documentation/qthelp/qthelpqtdoc.cpp
64

Now you're forcing an unnecessary copy constructor ^^'

cordlandwehr updated this revision to Diff 4905.Jul 2 2016, 4:26 PM
  • Avoid copy.
kfunk accepted this revision.Jul 3 2016, 10:48 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

+1

Closed by commit R32:4650682b0eff: Provide qmake arguments via list. (authored by cordlandwehr). · Explain WhyJul 3 2016, 1:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdocumentation/qthelp/qthelpqtdoc.cpp (11 lines)

Diff 4912

View Options

documentation/qthelp/qthelpqtdoc.cpp

Loading...