Differential D20649

[Notify by Portal] Support default action and priority hints
ClosedPublic
Actions

Authored by broulik on Apr 18 2019, 8:16 AM.

Details

Reviewers
jgrulich
Group Reviewers
Frameworks
Commits
R289:85bdacf738eb: [Notify by Portal] Support default action and priority hints
Test Plan

Compiles, untested as I couldn't figure out the flatpak build system stuff

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 18 2019, 8:16 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 18 2019, 8:16 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 18 2019, 8:16 AM
broulik updated this revision to Diff 56504.Apr 18 2019, 9:25 AM
  • Support high
  • Handle all switch cases
jgrulich accepted this revision.Apr 18 2019, 10:40 AM

Works for me. I tested both like the default action and urgency.

This revision is now accepted and ready to land.Apr 18 2019, 10:40 AM
Closed by commit R289:85bdacf738eb: [Notify by Portal] Support default action and priority hints (authored by broulik). · Explain WhyApr 18 2019, 10:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/notifybyportal.cpp (27 lines)

Diff 56507

View Options

src/notifybyportal.cpp

Loading...