Differential D20641

Fix uninitialized memory use when reading malformed tar files
ClosedPublic
Actions

Authored by aacid on Apr 17 2019, 5:51 PM.

Details

Reviewers
apol
Commits
R243:8d72247daeb3: Fix uninitialized memory use when reading malformed tar files
Summary

Don't try to read longlink if readLongLink fails

oss-fuzz #14310

Diff Detail

Repository
R243 KArchive
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10970
Build 10988: arc lint + arc unit
aacid created this revision.Apr 17 2019, 5:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 17 2019, 5:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Apr 17 2019, 5:51 PM
apol accepted this revision.Apr 17 2019, 10:18 PM
apol added a subscriber: apol.

Should maybe warn if it fails?

This revision is now accepted and ready to land.Apr 17 2019, 10:18 PM
aacid added a comment.Apr 17 2019, 10:21 PM
In D20641#452130, @apol wrote:

Should maybe warn if it fails?

I am not sure, but i don't think so, there's if's below that account for name and symlink being empty, so it's not a problem if this fails afaics

aacid closed this revision.Apr 17 2019, 10:21 PM

Revision Contents
Changeset List

PathPackages
Msrc/ktar.cpp (19 lines)

Diff 56463

View Options

src/ktar.cpp

Loading...