QtScript is not well maintained and deprecated in favor of QJSEngine.
This is still WIP because callDBus isn't yet ported.
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- port-scripting-to-qjsengine
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 11113 Build 11131: arc lint + arc unit
Comment Actions
Current status:
callDBus is still not ported. I have the following list of potential ways how to do it:
- Forward arguments to C++ implementation where the arguments will parsed and validated (similar to what we have in QScriptEngine implementation);
- In addition to 4 required arguments, specify N optional QVariant arguments;
- Expose DBusCall to QJSEngine, so we could wrap callDBus around DBusCall right in js.
In all three cases I'm worried about reply arguments, e.g. if there is any QDBusVariant reply argument, we have to unwrap it.
Comment Actions
Implement callDBus.
I went with the second option. Overall, the solution doesn't
look nice, but it works.
In long term, I think it would be nice to introduce a module
for such things, e.g.
const dbus = require('dbus'); dbus.makeMethodCall({ service: 'org.kde.KWin', path: '/KWin', interface: 'org.kde.KWin', method: 'supportInformation', onFinished: (text) => console.log(text), onError: (err) => console.log(err) });
Comment Actions
In all three cases I'm worried about reply arguments, e.g. if there is any QDBusVariant reply argument, we have to unwrap it.
That's true of the current state. Not just for QDBusVariant but for any complex type we demarshall that doesn't have a script-friendly metaobject attached.
In addition to 4 required arguments, specify N optional QVariant arguments;
That's what we do for i18n in kdeclarative. It's not super clever but pragmatically easy to read.
In long term, I think it would be nice to introduce a module
If we're thinking long term with API breaks it would be better to have something generic for all Plasma - as well as removing duplication between this and the QQmlEngine scripting.
Comment Actions
Argh, it's not possible anymore to do
client.geometry = { x: 0, y: 0, width: 42, height: 73 };
Potential solution would be to introduce some sort of Qt.rect, but that would break existing scripts. :(
This comment was removed by davidedmundson.
Comment Actions
Given that we have to break compatibility, KWin 6 is probably a good time to port scripting.