Remove TODO
AbandonedPublic

Authored by shubham on Apr 17 2019, 5:27 PM.

Details

Reviewers
dfaure
apol

Diff Detail

Repository
R241 KIO
Branch
todo
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10967
Build 10985: arc lint + arc unit
shubham created this revision.Apr 17 2019, 5:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 17 2019, 5:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
shubham requested review of this revision.Apr 17 2019, 5:27 PM
apol requested changes to this revision.Apr 17 2019, 10:12 PM
apol added a subscriber: apol.

I don't think you understood the TODO. Also this change breaks ABI, since const it's part of it.
The TODO talks about adding a startTimer method and deprecating timer (which it already is).

This revision now requires changes to proceed.Apr 17 2019, 10:12 PM
shubham abandoned this revision.Apr 18 2019, 3:17 AM