Differential D20633

Small cleanup for jp2kloader.cpp
ClosedPublic
Actions

Authored by mvetter on Apr 17 2019, 11:18 AM.

Details

Reviewers
cgilles
Group Reviewers
Digikam
Summary

When looking at jp2kloader.cpp I found some small things that can be improved. I'm mainly doing this to get to know the KDE/digikam workflow.
I'm not sure whether I selected the right repository below. Lets give me some feedback :)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
mvetter requested review of this revision.Apr 17 2019, 11:18 AM
mvetter created this revision.
cgilles added a comment.Apr 17 2019, 11:30 AM

Code to patch much come from git/master branch.

mvetter added a comment.EditedApr 17 2019, 11:35 AM

I checked out master a couple of days ago. Then created this patch. Nothing in jp2kloader.cpp changed inbetween checkout and change.

When creating this entry I could add an 'revision' and I selected the latest I could find. Removed it now. Is that better?

mvetter removed R832 Digikam as the repository for this revision.Apr 17 2019, 11:40 AM
cgilles added a comment.Apr 17 2019, 12:12 PM

no need, all is fine.

This revision is now accepted and ready to land.Apr 17 2019, 12:16 PM
cgilles closed this revision.Apr 17 2019, 12:16 PM
mvetter added a comment.Apr 17 2019, 12:32 PM

Cool! Thanks!
Maybe next time git am / git apply would be good to preserve the authorship and subject and description :)

cgilles added a comment.Apr 19 2019, 7:10 AM

You are right. git apply is better so far than patch command...

Gilles

Revision Contents
Changeset List

Diff 56428

View Options

core/libs/dimg/loaders/jp2kloader.cpp

Loading...