Fix build with Qt 5.6
ClosedPublic

Authored by wbauer on Apr 17 2019, 9:01 AM.

Details

Reviewers
cgilles
Group Reviewers
Digikam
Summary

The parent argument to QAction::QAction() is optional only since Qt 5.7, but the specified minimum Qt version is 5.6.0.
So explicitly pass nullptr, which is the default value in 5.7 and later.

Test Plan

Builds fine with Qt 5.6.2 now, I got these compiler errors before:

/home/abuild/rpmbuild/BUILD/digikam-6.1.0/core/libs/dimg/filters/curves/curvesbox.cpp: In member function 'void Digikam::CurvesBox::setup()':
/home/abuild/rpmbuild/BUILD/digikam-6.1.0/core/libs/dimg/filters/curves/curvesbox.cpp:232:67: error: no matching function for call to 'QAction::QAction(QString)'
     d->resetChannelAction     = new QAction(i18n("Reset &Channel"));
                                                                   ^
...
/home/abuild/rpmbuild/BUILD/digikam-6.1.0/core/libs/dimg/filters/curves/curvesbox.cpp:233:63: error: no matching function for call to 'QAction::QAction(QString)'
     d->resetChannelsAction    = new QAction(i18n("Reset &All"));
                                                               ^

Still builds fine with later Qt versions (tested with 5.9.4, 5.9.7, and 5.12.2).

Diff Detail

Repository
R482 digiKam
Lint
Lint Skipped
Unit
Unit Tests Skipped
wbauer requested review of this revision.Apr 17 2019, 9:01 AM
wbauer created this revision.
This revision is now accepted and ready to land.Apr 17 2019, 9:23 AM
cgilles closed this revision.Apr 17 2019, 9:23 AM