Add CriticalNotification window type to PlasmaShellSurface protocol
ClosedPublic
Actions

Authored by broulik on Apr 17 2019, 8:27 AM.

Details

Reviewers

zzag

Group Reviewers

KWin

Commits

Test Plan

Compiles, tests adjusted and pass.

Repository

R127 KWayland

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Apr 17 2019, 8:27 AM

if (wl_proxy_get_version(d->surface) < ORG_KDE_PLASMA_SURFACE_ROLE_CRITICALNOTIFICATION_SINCE_VERSION) {
//handle error code
}

src/client/protocols/plasma-shell.xml
194	since="6" See https://github.com/wayland-project/wayland/blob/master/protocol/wayland.dtd

zzag added a subscriber: zzag.

zzag added inline comments.

src/client/protocols/plasma-shell.xml
194	Also, folks usually put <!-- Version N additions --> :-)

This revision is now accepted and ready to land.Apr 26 2019, 1:04 PM

Please land together with other revisions.

			Path	Packages
M			autotests/client/test_plasmashell.cpp (1 line)
M			src/client/plasmashell.h (3 lines)
M			src/client/plasmashell.cpp (4 lines)
M			src/client/protocols/plasma-shell.xml (4 lines)
M			src/server/plasmashell_interface.h (3 lines)
M			src/server/plasmashell_interface.cpp (5 lines)
M			tests/plasmasurfacetest.cpp (4 lines)

Status	Author	Revision
Closed	broulik	D20630 [Dialog] Add CriticalNotification type
Closed	broulik	D20629 Support CriticalNotification type and place it in a CriticalNotificationLayer
Closed	broulik	D20627 Introduce CriticalNotificationType
Closed	broulik	D20631 Support CriticalNotification window type
Closed	broulik	D20628 Add CriticalNotification window type to PlasmaShellSurface protocol