Introduce CriticalNotificationType
ClosedPublic

Authored by broulik on Apr 17 2019, 8:24 AM.

Details

Summary

This is a dedicated window type indicating a critical notification that is more urgent than a regular notification and may be shown even on top of fullscreen windows.

Test Plan

Compiles, tests adjusted and pass

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 17 2019, 8:24 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 17 2019, 8:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 17 2019, 8:24 AM
zzag accepted this revision.Apr 26 2019, 1:27 PM
zzag added subscribers: graesslin, zzag.

Hmm, in general this is quite delicate case because KWin/X11 is feature frozen...

Given that there is no other way around (except using above state for critical notifications or letting plasmashell keep track of fullscreen state), the only option is to break the rule. :/

But you may still want to wait for input from other KWin folks as well, more specifically from @graesslin.

This revision is now accepted and ready to land.Apr 26 2019, 1:27 PM
davidedmundson accepted this revision.Apr 26 2019, 1:28 PM
This revision was automatically updated to reflect the committed changes.