Ran ctest
kmountpointtest still passes
Details
Details
- Reviewers
dfaure - Commits
- R241:acc6b9b71b51: Truncate trailing forward slashes(/)
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/core/kmountpoint.cpp | ||
---|---|---|
164–168 | That would turn "/boot/efi" into "/boot" !! I wonder, did kmountpointtest still pass? You want something like this instead: if (mountedFrom.endsWith('/')) { mountedFrom.chop(1); } |
Comment Actions
Patch looks good now ;-)
I'm curious about one more thing: what prompted this change? Did you have a mount point with a trailing slash, or was it just to "fix a TODO" (which, hehe, has been there since the very beginning of this code in 2003)?