Differential D20623

Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons
ClosedPublic
Actions

Authored by ndavis on Apr 17 2019, 2:36 AM.

Details

Reviewers

broulik
ngraham

Group Reviewers

VDG
Plasma

Commits

R242:bd8264e92869: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze…

Test Plan

media.svg:

drive.svg:

plasmavault_error.svg:

plasmavault:

list.svg:

go.svg:

audio.svg:

edit.svg:

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ndavis created this revision.Apr 17 2019, 2:36 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 17 2019, 2:36 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ndavis requested review of this revision.Apr 17 2019, 2:36 AM

Harbormaster completed remote builds in B10951: Diff 56407.Apr 17 2019, 2:36 AM

ndavis edited the test plan for this revision. (Show Details)Apr 17 2019, 2:40 AM

One concern:

Previously, the go-up icon in go.svg used a completely different style from the other go-* icons. Does anyone know why that was? I can't find any reason for it to use a different style. It's not the same as the arrow used in the system tray, because that one is one of the 4 variants of expander-* from notification.svg.

Old style go-up:

ngraham mentioned this in D20576: Add new notifications KCM.Apr 17 2019, 1:45 PM

This looks fine to me, but let's let a Plasma person weigh in too. :)

Volume icon are consistent now, Vault icon in tray is prettier (imho), media controls look unchanged/fine, folder view nav buttons look fine/better, lgtm

This revision is now accepted and ready to land.Apr 17 2019, 4:28 PM

ngraham accepted this revision.Apr 17 2019, 5:00 PM

ngraham mentioned this in D20637: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category.Apr 17 2019, 5:16 PM

ngraham mentioned this in D20638: [Widget Explorer] Continue using a trash can icon for deleting delegates.

Submitted D20637 and D20638 to keep the Widget Explorer using the correct icons after this patch lands.

Closed by commit R242:bd8264e92869: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze… (authored by ndavis). · Explain WhyApr 17 2019, 5:52 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in R120:3cbd317a3d38: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category.Apr 17 2019, 6:07 PM

ngraham mentioned this in R119:7cb8db2d1b30: [Widget Explorer] Continue using a trash can icon for deleting delegates.

Revision Contents
Changeset List

			Path	Packages
M			src/desktoptheme/breeze/icons/audio.svg (324 lines)
M			src/desktoptheme/breeze/icons/drive.svg (111 lines)
M			src/desktoptheme/breeze/icons/edit.svg (98 lines)
M			src/desktoptheme/breeze/icons/go.svg (106 lines)
M			src/desktoptheme/breeze/icons/list.svg (83 lines)
M			src/desktoptheme/breeze/icons/media.svg (325 lines)
M			src/desktoptheme/breeze/icons/plasmavault.svg (187 lines)
M			src/desktoptheme/breeze/icons/plasmavault_error.svg (187 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56407	8431223		Apr 17 2019, 2:36 AM	★	★
Diff 2	56464	0ff81fe	R242:bd8264e92869428c0af84a6b8d2b19e518fa5ebe	Apr 17 2019, 5:52 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8ef4c275324d	6fb0a8fcc790	843122354211	Noah Davis	Update audio, drive, edit, go, list, media, plasmavault icons to match breeze… (Show More…)	Apr 15 2019, 7:17 PM