Initialise the orientation sensor at start
ClosedPublic

Authored by apol on Apr 17 2019, 12:34 AM.

Details

Summary

We want to set the right orientation as the system starts.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 17 2019, 12:34 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 17 2019, 12:34 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Apr 17 2019, 12:34 AM
zzag added a subscriber: zzag.Apr 17 2019, 6:25 PM
zzag added inline comments.
orientation_sensor.cpp
100

emit

Hmm, is it a typo?

Also, is there a reason why updateState should be called here (and not in setEnabled)?

apol marked an inline comment as done.Apr 17 2019, 10:47 PM
apol added inline comments.
orientation_sensor.cpp
100

Ah yes, my bad.

setEnabled is used to disable the sensor altogether.

apol updated this revision to Diff 56483.Apr 17 2019, 10:47 PM
apol marked an inline comment as done.

address zzag's comment

zzag accepted this revision.Apr 21 2019, 9:56 PM

codewise looks fine, though keep in mind that I didn't test this patch; you may want to wait for another "+1".

This revision is now accepted and ready to land.Apr 21 2019, 9:56 PM
davidedmundson accepted this revision.Apr 21 2019, 10:09 PM
This revision was automatically updated to reflect the committed changes.