Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"
ClosedPublic

Authored by kossebau on Apr 16 2019, 1:02 PM.

Details

Summary

During Pre-Plasma5 the hard-coded height of 20 of the progressbar was
changed to instead be taken from the theme via the "hint-bar-size":
commit cee9c928e3855b68daf14760ed71aa961f231172

As fallback for old themes in absence of the hint the default height
since some time later has been derived from the sum of the heights of
the elements "bar-inactive-top" & "bar-inactive-bottom".

Which though for the Air and Oxygen themes results in the small heights
of respective 10 & 4. As a result the visual appearance of the theme
differs from what people remember of the time when the themes were
designed.
Ideally the theme designer would tune the actual value to something they
prefer. Until then setting the hint to restore the visual appearance over
the currently pretty slim or even too slim one should improve things
already.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 16 2019, 1:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 16 2019, 1:02 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 16 2019, 1:02 PM

Anyone brave enough for a shipit? :)

This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2019, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Given also on irc, no-one showed any interest for Air/Oxygen ,going to just push this, having at least one +1. Thanks for that one :)