Fix MobileTextSelection namespacing
ClosedPublic

Authored by broulik on Apr 16 2019, 7:49 AM.

Details

Reviewers
mart
hein
lbeltrame
Group Reviewers
Plasma
Summary

It is all in MobileTextSelection instead of Private now.

BUG: 400983

Test Plan

I dont understand why in every component there's two of them, one in a Component and the other not but whatever. This works now.

Note that when moving files about in plasmacomponents 3 you must do a clean build as our cmake foo to change the import numbers doesn't pick that up which is probably why this breakage went unnoticed. It also only broke here once I did a clean build or got the packages shipped from neon... Also, I would appreciate if you could test media controller when you do plasma components 3 changes as this seems to be the only user of that stuff right now and constantly breaks for doing so ...

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 16 2019, 7:49 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 16 2019, 7:49 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 16 2019, 7:49 AM
broulik edited the summary of this revision. (Show Details)
broulik added a reviewer: lbeltrame.
lbeltrame accepted this revision.Apr 16 2019, 9:17 AM
This revision is now accepted and ready to land.Apr 16 2019, 9:17 AM
mart added a comment.Apr 16 2019, 9:53 AM

sorry, didn't notice it :(