Differential D20570

[FrameSvgItem] Respect smooth property
ClosedPublic
Actions

Authored by broulik on Apr 15 2019, 10:36 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:2a636d66712f: [FrameSvgItem] Respect smooth property
Test Plan

Set smooth: true, rotated it, didn't look jagged anymore

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 15 2019, 10:36 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 15 2019, 10:36 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 15 2019, 10:36 AM
broulik planned changes to this revision.
mart added a subscriber: mart.Apr 15 2019, 10:38 AM

FrameItemNode needs the same

broulik updated this revision to Diff 56289.Apr 15 2019, 10:40 AM
  • Also update corner nodes
mart accepted this revision.Apr 15 2019, 10:42 AM
mart added inline comments.
src/declarativeimports/core/framesvgitem.cpp
95

could have here
frameSvg->smooth() ? QSGTexture::Linear : QSGTexture::Nearest;

to make the patch smaller?

anyways, i'm fine with either.. this one calculates the sace only once so may be arguued to be better

This revision is now accepted and ready to land.Apr 15 2019, 10:42 AM
Closed by commit R242:2a636d66712f: [FrameSvgItem] Respect smooth property (authored by broulik). · Explain WhyApr 15 2019, 10:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56290

View Options

src/declarativeimports/core/framesvgitem.cpp

Loading...