Differential D20560

Incidence Dialog: don't show an empty message widget initially.
ClosedPublic
Actions

Authored by dfaure on Apr 14 2019, 9:57 PM.

Details

Reviewers
kfunk
mlaurent
Commits
R78:e8bb93c71700: Incidence Dialog: don't show an empty message widget initially.
Summary

This is a regression introduced by commit 6b8797144d3b68a90aff.
Looks like we can't trust Qt Designer to keep hidden things hidden,
so better do it in actual code.

Test Plan

"New Event" no longer shows a blue rectangle at the top of the dialog.

Diff Detail

Repository
R78 PIM: Incidence Editor
Branch
Applications/19.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10877
Build 10895: arc lint + arc unit
dfaure created this revision.Apr 14 2019, 9:57 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 14 2019, 9:57 PM
dfaure requested review of this revision.Apr 14 2019, 9:57 PM
mlaurent accepted this revision.Apr 15 2019, 5:01 AM
This revision is now accepted and ready to land.Apr 15 2019, 5:01 AM
kfunk added a comment.Apr 15 2019, 5:26 AM

Uh, sorry.

Thanks for fixing!

dfaure closed this revision.Apr 15 2019, 6:55 AM

Revision Contents
Changeset List

PathPackages
Msrc/incidencedialog.cpp (1 line)

Diff 56249

View Options

src/incidencedialog.cpp

Loading...