[Digital Clock] Hide agenda if no calendar event plugins are enabled
ClosedPublic

Authored by broulik on Jun 30 2016, 9:17 PM.

Details

Summary

The agenda doesn't add a lot of usefulness if there aren't any appointments to be shown.
The weekday and date is also shown in the tooltip and I can see that people might prefer the older more compact look.

BUG: 364455
FIXED-IN: 5.7.1

Test Plan

Enabled holidays, got the agenda part
Disabled holidays, agenda got hidden.
Ensured that margins around look sane.

Probably needs someone with a ton of appointments to look whether the margins between agenda and calendar are still ok when there's a scrollbar.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4877.Jun 30 2016, 9:17 PM
broulik retitled this revision from to [Digital Clock] Hide agenda if no calendar event plugins are enabled.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design, dvratil.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 30 2016, 9:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this revision to Diff 4878.Jun 30 2016, 9:20 PM

Fix spacing between scrollview of agenda part and calendar grid

I'm asking the bad question now: how do we autotest that?

mart accepted this revision.Jul 1 2016, 8:40 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jul 1 2016, 8:40 AM
mart added a comment.Jul 1 2016, 8:41 AM

I'm asking the bad question now: how do we autotest that?

don't know, would need the testing stuff for applets apo l did.
so far qt too old in ci for it iirc?

so far qt too old in ci for it iirc?

It's still timing out on ci, but that's not due to too old Qt. We have 5.6.2 on build.kde.org.

This revision was automatically updated to reflect the committed changes.