Do you think you could include this in the tests/lauri.xml and lauri.po?

Hello Albert,

Do you think you could include this in the tests/lauri.xml and lauri.po?

Yes, that should be possible. I'll do it asap.

I also have another fix for another situation that currently produces broken XML:

<para>Some text 1<itemizedlist>
     ...
</itemizedlist>Some text 2</para>

My fix works, but only if the <itemizedlist> starts on same line as Some text 1. I would need the help of a developer who knows better parser.cpp code than me in order to create a better fix.

Would you accept to discuss it by email, or would you know someone who could help?

Without the - 1, you get the bug:

$ make

      (...)

[100%] Generating lauri_de.xml
can't find
Extra text we want intact
in
xtra text we want intact </para>

IMHO good for merging.

Although beware I'm not German, so the German texts might not be perfect.

Ok, we should go with this, at least now we have a case that proves it's needed. if it breaks something else people will have to fix that while keeping this not broken :)

Will you commit it or want me to?

Also the xml2pot we use for kde sources in scripty comes from ubuntu so this will take a while to trickle down to there, is this something you need for our sources or for some "external use"?

About the other question i don't think there's anyone at this point that actually knows/remembers how parser.cpp works. But if you want i can try reading your emails and give you insight, but don't really expect much

My big suggestion is use testscases.

In D20559#453457, @aacid wrote:

Ok, we should go with this, at least now we have a case that proves it's needed. if it breaks something else people will have to fix that while keeping this not broken :)

Yes, the addition to lauri.xml proves it's needed.

I don't think it breaks anything, I already used it on massive amount of XML data.

Will you commit it or want me to?

Please do, I have no idea how to commit it. Maybe next time, you'll explain me how to proceed.

Also the xml2pot we use for kde sources in scripty comes from ubuntu so this will take a while to trickle down to there, is this something you need for our sources or for some "external use"?

I think KDE documentation avoids this case - either pure chance, or people noticed something was wrong and avoided triggering the problem.

I don't need you to fix it for my "external use" - I already use the fixed version (I forked on github). I just wanted to contribute my fix back upstream (= to KDE project).

About the other question i don't think there's anyone at this point that actually knows/remembers how parser.cpp works. But if you want i can try reading your emails and give you insight, but don't really expect much

I could try to speak to Coolo. I think the code is from him. But maybe he does not event remember.

My big suggestion is use testscases.

I'll provide you one for the remaining problem, that's easy to reproduce.