Don't use qAsConst over a temporary variable
ClosedPublic

Authored by dfaure on Apr 14 2019, 5:47 PM.

Details

Summary

(will crash because the temporary will be destroyed before being used)

Detected with

ag -sr qAsConst'\([^)]*\(' .
Test Plan

builds

Diff Detail

Repository
R290 KPackage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10863
Build 10881: arc lint + arc unit
dfaure created this revision.Apr 14 2019, 5:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 14 2019, 5:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Apr 14 2019, 5:47 PM
dfaure updated this revision to Diff 56230.Apr 14 2019, 5:49 PM

Improve regexp to avoid catching kbuildsycoca.cpp

mlaurent accepted this revision.Apr 14 2019, 6:13 PM

I used you command and see the same problem.

This revision is now accepted and ready to land.Apr 14 2019, 6:13 PM
dfaure closed this revision.Apr 14 2019, 6:15 PM