Retitle button "Close" to "Close file" when a file has been removed on disk
ClosedPublic

Authored by meven on Apr 14 2019, 3:23 PM.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Apr 14 2019, 3:23 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptApr 14 2019, 3:23 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
meven requested review of this revision.Apr 14 2019, 3:23 PM
kossebau added inline comments.
src/dialogs/katedialogs.cpp
1294

Given this text ends on a button , use "&Close File".
See also https://hig.kde.org/style/writing/capitalization.html

More perfect might be even to use User Interface Markers in the comment, so translators have a clue what capitalization style they would prefer for their locale ->
i18nc("@action:button", "&Close file")
See also https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt

cullmann added a subscriber: cullmann.

Perhaps Nate has feedback, too.
I have no issues with this change.

meven updated this revision to Diff 56231.Apr 14 2019, 5:51 PM

Capitalization & add context for translation

meven marked an inline comment as done.Apr 14 2019, 5:52 PM
meven added inline comments.
src/dialogs/katedialogs.cpp
1294

Thank you for pointing it out :)

meven marked 2 inline comments as done.Apr 14 2019, 5:52 PM
ngraham accepted this revision.Apr 15 2019, 2:50 AM

+1 shipit!

This revision is now accepted and ready to land.Apr 15 2019, 2:50 AM
cullmann accepted this revision.Apr 15 2019, 3:49 AM
This revision was automatically updated to reflect the committed changes.